Skip to content

Hotfix/phase update bug fix[DEV] #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vikasrohit merged 2 commits into from
Aug 28, 2018
Merged

Hotfix/phase update bug fix[DEV] #2443

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a26eb9
Merge pull request #2404 from appirio-tech/hotfix/error_in_adding_new…
Aug 21, 2018
4eaf34e
Fixed bug while calculating change in startDate of a phase.
RishiRajSahu Aug 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/projects/actions/project.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,8 @@ export function updatePhase(projectId, phaseId, updatedProps, phaseIndex) {
const phaseStatusChanged = phase.status !== updatedProps.status
const productId = phase.products[0].id
const timeline = state.productsTimelines[productId] && state.productsTimelines[productId].timeline
const startDateChanged =updatedProps.startDate && updatedProps.startDate.diff(timeline.startDate)
const phaseStartDate = timeline ? timeline.startDate : phase.startDate
const startDateChanged = updatedProps.startDate ? updatedProps.startDate.diff(phaseStartDate) : null
const phaseActivated = phaseStatusChanged && updatedProps.status === PHASE_STATUS_ACTIVE
if (phaseActivated) {
updatedProps.startDate = moment().hours(0).minutes(0).seconds(0).milliseconds(0)
Expand Down