Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class MilestoneTypeAddLinks extends React.Component {
this.state = {
addedLinks: [],
isShowCompleteConfirmMessage: false,
isLinkAdded: true,
isLinkUpdating: false,
showExtensionRequestSection: true
}

Expand Down Expand Up @@ -87,9 +87,15 @@ class MilestoneTypeAddLinks extends React.Component {
const { addedLinks } = this.state
values.type = 'marvelapp'

// here we simulate uploading process for LinkList component
// as that component is uncontrollable and relies on the `isUpdating` property
this.setState({
addedLinks: [...addedLinks, values],
isLinkAdded: false
isLinkUpdating: true,
}, () => {
this.setState({
addedLinks: [...addedLinks, values],
isLinkUpdating: false,
})
})
}

Expand All @@ -101,7 +107,6 @@ class MilestoneTypeAddLinks extends React.Component {
addedLinks.splice(linkIndex, 1)
this.setState({
addedLinks,
isLinkAdded: false
})
}

Expand All @@ -117,7 +122,7 @@ class MilestoneTypeAddLinks extends React.Component {
const {
addedLinks,
isShowCompleteConfirmMessage,
isLinkAdded,
isLinkUpdating,
} = this.state

const isActive = milestone.status === MILESTONE_STATUS.ACTIVE
Expand Down Expand Up @@ -174,7 +179,7 @@ class MilestoneTypeAddLinks extends React.Component {
formAddButtonTitle="Add link"
formUpdateTitle="Editing a link"
formUpdateButtonTitle="Save changes"
isUpdating={isLinkAdded}
isUpdating={isLinkUpdating}
fakeName={`Design ${addedLinks.length + 1}`}
onFormAddOpen={this.onFormAddOpen}
onFormAddCancel={this.onFormAddCancel}
Expand Down