Skip to content

Support profile update for old profiles #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RishiRajSahu merged 4 commits into from
Nov 5, 2018
Merged

Support profile update for old profiles #2671

RishiRajSahu merged 4 commits into from
Nov 5, 2018

Conversation

@maxceem
Copy link
Collaborator

@maxceem maxceem commented Nov 5, 2018

  • Support old profiles which doesn't have connect_info trait
  • Support old profiles which have basic_info trait without categoryName defined
  • Added Country Select Dropdown
  • if we run code on DEV env I use connect_info
  • if we run code on PROD env I use customer_info

@maxceem maxceem requested a review from RishiRajSahu November 5, 2018 04:27
RishiRajSahu
RishiRajSahu approved these changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@RishiRajSahu RishiRajSahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RishiRajSahu RishiRajSahu merged commit 5fc4f85 into dev Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@RishiRajSahu RishiRajSahu RishiRajSahu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxceem @RishiRajSahu