Feature/subsections horizontal layout #2737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix: renamed spacing "space" to "codes" - fix: removed some unnecessary conditions and parentheses
RishiRajSahu
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Winning submission from F2F challenge #30078550 - Horizontal Layout for Subsections
To test, deploy the branch and use this template
http://local.topcoder-dev.com:3000/new-project/subsection-horizontal-layout
Note, there are two examples.
Full example:
Horizontal layout without
spacingstyles specified in template:Note, submisstion doesn't use
placeholderproperty for placeholders in these fields, instead it usestitle. I think it's good solution as most likely it's what we need. In case we would need another behaviour it would be easy to update it later I think.