Feature/team management autocomplete #2829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dev: Updating price config logic to read duration estimate as well one more test case for expression evaluator lint fixes pricing config changes fixed lint error Bringing back project estimate in dev lint fixes Replace JSON editor library because react-json-editor-ajrm is no longer maintained and is causing troubles with our web pack build which in turn causing issues in loading Connect in IE. Add config variable for Filepicker sources - enabled email changing - added `succesUrl` and `failUrl` params during email changing - show error which is returned from the server if email is not valid for change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a winning submission from challenge 30083313 - Topcoder Connect - Team Management - Autocomplete
This fixes issue #2735
Note, in the implementation I've asked to reuse the library we already use
react-select, which is also used for autocomplete in attachment permissions dialog.We still need to test it, and probably think about some UX improvements.
Also, for now we created a separate component from suggestion for attachments permissions.
Maybe we can/should merge them and use the same CSS style for them.
We also use a very old version of
react-select@0.9.1while the current version is2.3.0. This includes the fact that this old version causes some warnings in the browser console. So we consider updating it.