fixes isssue 2828 #2871
Merged
fixes isssue 2828 #2871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
reviewed
Mar 1, 2019
Collaborator
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
This change looks very good to me:
&& project.id === parseInt(match.params.projectId)
I've tried to remove the second change, and it still looks like everything still works good for me. Is there any particular case where we need it?
if (!props.projectTemplate) {
return null
}
Contributor
Author
|
@maxceem if (!props.projectTemplate) {
return null
}
strange you don't see it ...not sure! |
maxceem
approved these changes
Mar 1, 2019
Collaborator
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
Works good for me.
Thank you @sumitdaga
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.