Skip to content

Conversation

@rashmi73
Copy link
Contributor

No description provided.

Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good @rashmi73

Only one thing is missed. In mobile resolution, the My projects switch is also shown now, but for cutomers, we shouldn't show it:

image

@maxceem
Copy link
Collaborator

maxceem commented Apr 15, 2019

@rashmi73 found one more thing.

Currently, filters don't make any effect for the customer if we click them. To make them work we have to remove this code:
https://github.com/appirio-tech/connect-app/blob/dev/src/projects/actions/loadProjects.js#L23-L42

Make sure to update this line https://github.com/appirio-tech/connect-app/blob/dev/src/projects/actions/loadProjects.js#L46 to use criteria instead of requestCriteria after code removal.

Also, have fix lint errors if there are any.

Thank you.

Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good @rashmi73

Thank you.

@maxceem maxceem merged commit 6314bc4 into topcoder-archive:cf16 Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants