issue 2710 fix #2946
Merged
issue 2710 fix #2946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
requested changes
Apr 15, 2019
Collaborator
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
@Gauravseta in the Redux store I can see that pshah_customer has only one role Topcode User which mean he should be able to edit email. But it's disabled for him.
Also, to check if the user is a customer you can use the same rule as in other places, for example, this one https://github.com/appirio-tech/connect-app/blob/dev/src/projects/detail/containers/ProductTimelineContainer.jsx#L90
maxceem
approved these changes
Apr 16, 2019
Collaborator
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
Works good @Gauravseta
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.