issue 2899 fix #2947
Merged
issue 2899 fix #2947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
requested changes
Apr 15, 2019
Collaborator
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
@rashmi73 the reason for the issue which you found looks right. But I think the fix would not always work.
There are several places where we override the whole project object, so we can again have a situation when invites is not defined:
- https://github.com/appirio-tech/connect-app/blob/dev/src/projects/reducers/project.js#L242
- https://github.com/appirio-tech/connect-app/blob/dev/src/projects/reducers/project.js#L154
- https://github.com/appirio-tech/connect-app/blob/dev/src/projects/reducers/project.js#L161
- https://github.com/appirio-tech/connect-app/blob/dev/src/projects/reducers/project.js#L342
- https://github.com/appirio-tech/connect-app/blob/dev/src/projects/reducers/project.js#L375
As there are so many places, it feels that the more safe and easier approach would be to check if we have invites array inside these reducers before we try to push:
- https://github.com/appirio-tech/connect-app/blob/dev/src/projects/reducers/project.js#L517
- https://github.com/appirio-tech/connect-app/blob/dev/src/projects/reducers/project.js#L531
And if invites is not defined, then create an empty array first, before push to it.
What do you think?
Contributor
Author
|
@maxceem yes you are correct and implemented same. kindly check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.