Skip to content

Conversation

@codeMinter
Copy link
Contributor

No description provided.

@maxceem maxceem self-requested a review April 16, 2019 07:38
Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gurmeetb

Posts are shown in reverse order as required. But the load earlier posts currently is shown in old order:

image

load earlier posts button should be at the place where we are going to show old posts.

Other than that, works good.

Thanks.

@codeMinter
Copy link
Contributor Author

@maxceem are we sure we want this change, I revisited the details and it was expected to leave it that way, Refer the snapshot attached in final change details from you -

@maxceem
Copy link
Collaborator

maxceem commented Apr 16, 2019

@gurmeetb yes, we should make this change. This screenshot just shows the button which we have to take care about as we don't have a new design for this.

This button should work taking into account the new order and should be shown on the place where we "hide" old comments. In reverse order it's bottom.

@codeMinter
Copy link
Contributor Author

@maxceem no worries, updated MR with the change requested.

Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good @gurmeetb.

Thank you.

@maxceem maxceem merged commit e295b3b into topcoder-archive:cf16 Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants