Skip to content

Conversation

@maxceem
Copy link
Collaborator

@maxceem maxceem commented Apr 22, 2019

can we by pass the specific deliverable addon section when there is no addon for that particular deliverable e.g. as of now Deployment does not have any add on, we want to skip directly to the final summary screen when user selects only the Deployment as deliverable and answers all required question i.e. we want to skip the intermediate summary screen and the the empty screen which asks for selecting addons.

This is done. At the moment the solution uses section IDs to detect intermediate section and add-ons section:

section.id === 'summary-intermediate'
section.id === 'add-ons'

This binds the logic to the particular template. But anyway it looks like there is no other way to describe this logic or we should introduce some additional properties to define these sections.

I think we can use this solution until we get some additional requirements or other templates examples. We should use these IDs for now for these two sections.

@maxceem maxceem requested a review from vikasrohit April 22, 2019 01:43
Copy link

@vikasrohit vikasrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and seem like explicit id match is the quick and non complex solution for now. We will take care of more generic solution later when we get more use cases of this feature.

@maxceem
Copy link
Collaborator Author

maxceem commented Apr 22, 2019

@vikasrohit I've added an inline comment to the code as per discussion. And fixed template object mutation which has been there.

@vikasrohit
Copy link

Thanks @maxceem

@vikasrohit vikasrohit merged commit 80f2eea into dev Apr 22, 2019
@vikasrohit vikasrohit deleted the feature/skip-empty-addons branch May 6, 2019 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants