Update to v5 notifications api #3052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought, |
Collaborator
Author
|
v5 standard uses |
Collaborator
Author
|
here is the v5 standard document for reference (I'm not sure if it's hosted somewhere??) |
|
@gondzo how we are using next pages in connect for list-notifications ? changes are required there too ? |
Collaborator
Author
|
We aren't using it yet - we're just fetching a fixed number of notifications. That might even be ok since we always want to fetch all unread notifications, there is no pagination support |
|
Merging to dev as now tc-notifications is deployed to production with v5 changes and it is still backward compatible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.