Cf17 notifications reload subject #3069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes issue 2177
|
Thanks @maxceem for the detailed tests and comments for the issue. It would be really helpful refer #3035 (comment) for the issue and its fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vikasrohit I propose to merge the PR for the issue #2177
Please, check the final review #3035 (comment)
As that PR was merged to another branch, I created this PR for merging to DEV.
I didn't want to merge it as the approach with multiple
withRouterandlocationpassing feels prone to bugs.But as I don't have a good solution for this at the moment and have quite limited time and more priority tasks, I propose to merge it. As least until we first time come across any related issue. We can come back to this any time, as using the mentioned PR we can see all the places where we passed
locationor addedwithRouterfor this task. So if later we decide so we can revert these places and implement another way.The main reason for merging is that I'd like to test this functionality in general more to see if it works good in real life usage and if have any drawback. I guess we would add more such features in the future.