Skip to content

fixes issue 3065 #3073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vikasrohit merged 1 commit into from
May 30, 2019
Merged

fixes issue 3065 #3073

vikasrohit merged 1 commit into from
May 30, 2019

Conversation

@sumitdaga
Copy link
Contributor

@sumitdaga sumitdaga commented May 30, 2019

No description provided.

maxceem
maxceem approved these changes May 30, 2019
View reviewed changes
Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good. Thanks @sumitdaga

@maxceem
Copy link
Collaborator

maxceem commented May 30, 2019

@vikasrohit this is a fix for issue #3065.

In particular, it follows the same logic as for posts content:

  • if say i attch a file and then click on cancel button the attachment should also be gone. Same like content inside post
  • if there is content (meaning user has typed something in the input boxes) and we click outside ...the editor does not close. Same if we already attached files.

This PR looks good to me and can be merged to DEV.

@maxceem maxceem requested a review from vikasrohit May 30, 2019 09:22
@vikasrohit vikasrohit merged commit 9cd7807 into topcoder-archive:dev May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxceem maxceem maxceem approved these changes

@vikasrohit vikasrohit Awaiting requested review from vikasrohit

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sumitdaga @maxceem @vikasrohit