Skip to content

Hotfix/support multiple questions with same field name #3093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vikasrohit merged 2 commits into from
Jun 6, 2019
Merged

Hotfix/support multiple questions with same field name #3093

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24397b2
Handling the situation where we have multiple questions, which have s…
Jun 6, 2019
c0f7fde
Lint fix
Jun 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/helpers/wizardHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,13 +1004,32 @@ export const updateNodesByConditions = (template, project, productTemplates) =>
export const removeValuesOfHiddenNodes = (template, project) => {
let updatedProject = project

const fieldMap = {}
// iterates over all nodes to find out nodes with same fieldName
forEachNode(template, (nodeObject, node) => { // eslint-disable-line no-unused-vars
if (nodeObject.fieldName ) {
if (!fieldMap[nodeObject.fieldName]) {
fieldMap[nodeObject.fieldName] = []
}
fieldMap[nodeObject.fieldName].push(nodeObject)
}
})

forEachNode(template, (nodeObject, node) => {
const level = getNodeLevel(node)
let hasVisbleNodeWithSameCond = false
if (nodeObject.fieldName) {
fieldMap[nodeObject.fieldName].forEach((no) => {
if (!_.get(no, '__wizard.hiddenByCondition')) {
hasVisbleNodeWithSameCond = true
}
})
}

switch(level) {
// if some question is hidden, we remove it's value from the project data
case LEVEL.QUESTION:
if (_.get(nodeObject, '__wizard.hiddenByCondition') && _.get(updatedProject, nodeObject.fieldName)) {
if (_.get(nodeObject, '__wizard.hiddenByCondition') && !hasVisbleNodeWithSameCond && _.get(updatedProject, nodeObject.fieldName)) {
updatedProject = update(updatedProject, unflatten({
[nodeObject.fieldName]: { $set: undefined }
}))
Expand Down