Skip to content

Github issue#3097, Project does not load when project plan (phases) is empty #3099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vikasrohit merged 1 commit into from
Jun 7, 2019
Merged

Github issue#3097, Project does not load when project plan (phases) is empty #3099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/helpers/templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export function getProjectProductTemplates(productTemplates, projectTemplates, p
}

const projectTemplate = getProjectTemplateById(projectTemplates, project.templateId)
const phases = _.get(projectTemplate, 'phases', []) // TODO we can log error details here for missing project template
const phases = _.get(projectTemplate, 'phases', {}) // TODO we can log error details here for missing project template
const projectProductTemplates = []

Object.keys(phases).forEach((phaseName) => {
Expand Down
5 changes: 3 additions & 2 deletions src/projects/detail/ProjectDetail.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,9 @@ const spinner = spinnerWhileLoading(props =>
props.error && props.error.type === LOAD_PROJECT_FAILURE ||
// old project or has projectTemplate loaded
((props.project && props.project.version !== 'v3') || props.projectTemplate)
// has product templates loaded
&& props.productTemplates.length > 0
// has all product templates loaded (earlier it was checking project specific product templates only
// which can be empty when we have empty project plan config for the template)
&& props.allProductTemplates.length > 0
)
)
const ProjectDetailView = (props) => {
Expand Down