Fix DraftJS link parsing issue #3101
Conversation
…h_empty_project_plan Github issue#3097, Project does not load when project plan (phases) is empty
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
Thanks @vigneshTheDev it works good for me. There is only one small comment regarding the code.
@vikasrohit I've tested this new PR it works good for me and handles automatic link creation for links in text. And it also preserves formatting.
There were some changes in logic so I've tested for any regression issues regarding link creation and showing a popup and did find any. But it would be great if you could also check the link creation.
| el: () => { | ||
| return this.element | ||
| } | ||
| }) |
There was a problem hiding this comment.
@vigneshTheDev Looks like the previous code is equivalent to the new one. Maybe we can revert this change and keep the previous code.
There was a problem hiding this comment.
Yes. Correct. I changed it to enable debugging. I'll make the change and push it
There was a problem hiding this comment.
Hi @maxceem, looks like the pull request is closed. Shall I submit a new PR with the change?
|
@maxceem lets merge this in dev only as regular fix. I think we can afford the current issue as it is not limiting users to use our platform in any way. This is additional functionality that works partially (i.e. when you paste the link only it works, right?). So, I guess we should be good to have it as regular fix. |
|
@vikasrohit yes, makes sense. |
4 participants
No description provided.