issue 3051 fix

[PrakashDurlabhji]

No description provided.

[maxceem]

@PrakashDurlabhji

Provided fix doesn't work for me. As soon as we open the dropdown with notification, all the notifications should be marked as seen and red cue should disappear, but it doesn't disappear for me, see video https://monosnap.com/file/618NC2xK5cxoZwi0rqSZSwRFQkqFxL

I see there is only one small change in the PR, did you submit all the update code?

[PrakashDurlabhji]

@maxceem
1.can you please confirm if "isOpen" was ever working in NotificationDropDownContainer?
because suddenly there is an issue.
2. also, if route "notification/seen" exists?

[maxceem]

@PrakashDurlabhji

1.can you please confirm if "isOpen" was ever working in NotificationDropDownContainer?
because suddenly there is an issue.

You may check the current version on https://connect.topcoder-dev.com/ - I don't see any issues with isOpen.

2. also, if route "notification/seen" exists?

Do you mean the API URL to mark notifications seen? The url is https://api.topcoder-dev.com/v5/notifications/${id}/seen, where ${id} - is id of the notification. We already have a service method for it https://github.com/appirio-tech/connect-app/blob/dev/src/routes/notifications/services/notifications.js#L20

[PrakashDurlabhji]

@maxceem update done

[maxceem]

Thanks for update @PrakashDurlabhji

I cannot run code with the latest update, getting an error:

Does it work for you?

[PrakashDurlabhji]

@maxceem i making a commit, well tested and red cue disappears perfectly on opening notifications by clicking on bell.
just 10 mins more

[maxceem]

@PrakashDurlabhji good, I'll review as soon as you post an update.

[PrakashDurlabhji]

@maxceem commit updated. kindly verify thank you

[maxceem]

Thanks, @PrakashDurlabhji after the last update works great.

There are some code issues to fix before I can merge it. Please, have a look at the 3 code comments.

Also, there are a couple of other code issues:

1. There are lint errors:

   

2. As we don't use lastVisited visited anymore we should remove all the related code which is not more in use. Like lastVisited from the redux store, visitNotifications action, onVisitNotifications method, VISIT_NOTIFICATIONS action and so on

[PrakashDurlabhji]

@maxceem all updated

[maxceem]

Almost perfect @PrakashDurlabhji

There are is a couple of places with lastVisited left (which is not in use anymore):

Also, VISIT_NOTIFICATIONS is left

and it causes a warning:

[maxceem]

@PrakashDurlabhji one lint error is left, also VISIT_NOTIFICATIONS is not removed completely.

[maxceem]

Everything is good now @PrakashDurlabhji.

Thanks.