[HOTFIX] [PROD] post release 2.4.13 #3185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikasrohit
reviewed
Jul 17, 2019
vikasrohit
reviewed
Jul 17, 2019
| } */ | ||
| const powerUserRoles = [ROLE_CONNECT_COPILOT, ROLE_CONNECT_MANAGER, ROLE_ADMINISTRATOR, ROLE_CONNECT_ADMIN] | ||
| const isCustomer = _.intersection(user.roles, powerUserRoles).length === 0 | ||
| const role = isCustomer ? 'Customer' : 'Member' |
There was a problem hiding this comment.
@maxceem just a note, it was showing me as Customer even when I have power user roles.
Collaborator
Author
There was a problem hiding this comment.
@vikasrohit I guess it was an issue with logic. If I'm not mistaken we didn't have direct requirements from the product team on what text should be shown here. So I've simplified logic to always show User since for now.
… successful creation of a new topic on the Messages tab
…ubfolders in "Assets Library""
vikasrohit
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.