Hotfix/post release 2.4.13.7 #3217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2019
vikasrohit
approved these changes
Jul 25, 2019
|
@maxceem the strange thing is that why this issue started to appear only after our recent release. The message which has this problem was created on Jun 24, so it should have appeared before our release as well. |
|
Also, could you please log a ticket and update your investigation results there. |
Collaborator
Author
That is strange, but so far I don't see any reason how it could happen only after the release but not before.
Created #3219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix rendering DraftJS message when block doesn't have inline content
Fix for the issue with rendering
>in DraftJS.The root of the issue is that in code we create a block first, and after when we find
inlinecontent inside that block we set some properties of the block liketext. But if there is no inline content, then such properties of the block stay unutilized which causes an error later as a block is not fully defined.So the solution is set the default values of properties for the block as it has empty inline content. And if there is some inline content, such properties would be updated.