Skip to content

fix phone number alert in profile settings #3287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RishiRajSahu merged 1 commit into from
Aug 29, 2019
Merged

fix phone number alert in profile settings #3287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/routes/settings/routes/profile/components/ProfileSettingsForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ class ProfileSettingsForm extends Component {
}

onBusinessPhoneCountryChange({ country, externalChange }) {
const { businessPhoneValid } = this.state
const { businessPhoneValid, countrySelected: previousSelectedCountry } = this.state

if (country && country.code) {
if (this.state.countrySelected !== country.name && country.name) {
if (previousSelectedCountry !== country.name && country.name) {
// when country code of business phone changes, the country selection should change automatically
this.refs.countrySelect.setValue(country.name)
this.setState({
Expand All @@ -78,7 +78,9 @@ class ProfileSettingsForm extends Component {
// external change means, the user didn't change the phone number field.
// But it was automatically changed due to country selection change. In such case, we should show
// the alert under country selection only.
if (!externalChange) {
const countryName = country && country.name
const countryCodeChanged = countryName && previousSelectedCountry && countryName !== previousSelectedCountry
if (!externalChange && countryCodeChanged) {
this.setState({
businessPhoneDirty: true
})
Expand Down