-
Notifications
You must be signed in to change notification settings - Fork 136
upgrade project api to v5 #3360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade project api to v5 #3360
Conversation
upgrade project api to v5
|
@maxceem
I also upgraded all project attachments api but it throw some random error |
fix lint error
|
Thanks @suppermancool |
|
@maxceem we don't have |
|
@maxceem also don't have some other fields like: 'members', 'actualPrice', 'estimatedPrice', 'createdAt', 'updatedAt', 'createdBy', 'updatedBy', 'details', 'lastActivityAt', 'lastActivityUserId', 'version', 'templateId', 'description' |
|
@suppermancool I'm deploying the fix for your two comments above. I will update shortly (10 - 20 mins). |
upgrade /projects api
|
@maxceem ok done in the latest commit, i pass all fields to request the |
maxceem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please have a look at my comments below.
The Project Service has been redeployed, and filtering suppose to work. Let me know if you still face any issues.
Please, comment out the code with filter by segment we don't support it at the moment.
|
@suppermancool when I try to filter projects using:
Not filters are added to the URL request Also, note, that we have some default query params which are added to this request even without any filters: |
update with feedback
update some params
fix input params
revert code
remove redundant code
|
@maxceem for this #3360 (comment) All done in the latest commit |
maxceem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think limit, offset are changed to perPage, page.
Thanks for pointing this out.
All works good now as per the current version of Project Service we have.
Thank you for rapid updates @suppermancool!
|
FYI @vikasrohit we have now draft v5 version of Connect App, which points to the currently deployed version of https://circleci.com/gh/topcoder-platform/projects-api. Not everything yet works there due to an outdated version of Project Service or some API inconsistencies. But already can be checked out. So once you confirm a separate DEV env for this, we may start deploying it. |




upgrade project api to v5