Fix: some lines disappearing during editing in editor based on Draftjs #3469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renders nested code block as inline block except in case of list item it renders code as fence. - In case of multiple paragraph inside list item, only the last one was being considered. Fix this to consider all paragraph inside list item.
maxceem
approved these changes
Dec 25, 2019
Collaborator
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
Thanks, @sanju-singh.
This PR has been tested during the challenge and works as described in this comment #3456 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this to consider all paragraph inside list item.