Skip to content

[HOTFIX] [PROD] fix when updatedBy m2m #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vikasrohit merged 1 commit into from
Dec 30, 2019
Merged

[HOTFIX] [PROD] fix when updatedBy m2m #3471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/projects/actions/loadProjects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ const getProjectsWithMembers = (dispatch, getState, criteria, pageNum) => {

})
// this is to remove any nulls from the list (dev had some bad data)
_.remove(userIds, i => !i)
// in particular, remove negative userId which are related to M2M users
_.remove(userIds, i => !i || i < 0)
// return if there are no userIds to retrieve, empty result set
if (!userIds.length)
resolve(true)
Expand Down