Skip to content

Conversation

@yoution
Copy link
Collaborator

@yoution yoution commented Feb 5, 2020

No description provided.

Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution In general works great. Though when I'm resizing the screen on some sizes there is a gap appears between the wave and gray background:

image

Most likely it's because of using transform: scale I guess for the vertical curve we don't need to scale so we can remove the transform.
For the vertical curve I guess we cannot avoid using the scale, but I also don't see any visual issues so we should good here.

@yoution
Copy link
Collaborator Author

yoution commented Feb 5, 2020

@maxceem I try another method, I add transform: translateZ(0);. if I remove scale, the issue still exist. please review

@maxceem
Copy link
Collaborator

maxceem commented Feb 5, 2020

@yoution I can still reproduce the issue even with transform: translateZ(0):

image

@yoution
Copy link
Collaborator Author

yoution commented Feb 5, 2020

so just remove scale ?

@yoution
Copy link
Collaborator Author

yoution commented Feb 5, 2020

@maxceem please review again, remove scale and add 'float:right' may perfect

@maxceem
Copy link
Collaborator

maxceem commented Feb 5, 2020

so just remove scale ?

Looks like removing scale doesn't help.

@maxceem please review again, remove scale and add 'float:right' may perfect

thanks, I will check it out tomorrow

Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good for me now, thanks!

@maxceem maxceem merged commit fbd8f72 into topcoder-archive:dev Feb 6, 2020
@yoution yoution deleted the issue-3513 branch February 6, 2020 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants