Issue 3868 fix #3934
Merged
Issue 3868 fix #3934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
requested changes
Apr 19, 2020
Collaborator
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
@PrakashDurlabhji fix looks great now, though there are some issues.
-
On the project details page we also use this component with
read more. When hover mouse the cursor should behand, see https://connect.topcoder-dev.com/projects/4119/specification. But after the fix it's not hand anymore
-
There are some lint errors:
-
See the comment below about
showLinkURL.
maxceem
requested changes
Apr 20, 2020
Collaborator
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
@PrakashDurlabhji 2 and 3 are fixed. But 1 is not fixed.
Contributor
Author
|
@maxceem updating |
Contributor
Author
|
@maxceem PR updated |
maxceem
approved these changes
Apr 20, 2020
Collaborator
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
@PrakashDurlabhji works well now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.