Skip to content

[HOTFIX] [PROD] Patch release 2.12.1 #4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RishiRajSahu merged 1 commit into from
Sep 29, 2020
Merged

[HOTFIX] [PROD] Patch release 2.12.1 #4139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/components/Footer/Footer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ const Footer = () => {

// TODO this looks like a bad way of doing it, I think it should be re-factored
const shouldHideOnDesktop = isProjectDetails || isCreateProject || isNotificationsPage || isSettingsPage
// on mobile show footer only when user is logged-out, so only root page is available
const shouldHideOnMobile = window.location.pathname !== '/'

return (
<MediaQuery minWidth={SCREEN_BREAKPOINT_MD}>
Expand All @@ -39,9 +37,8 @@ const Footer = () => {
</div>
)
} else {
return (shouldHideOnMobile ? null :
{/*<FooterV2 />*/}
)
{/* never show footer on mobile */}
return null
}
}}
</MediaQuery>
Expand Down