load and cache all skills for skills question #4211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
requested changes
Dec 13, 2020
Collaborator
There was a problem hiding this comment.
Thanks, @vigneshTheDev it works great.
Only in the edge case when API request fails it cases uncaught error in the code:
We can set empty skills list if error happens so the code doesn't get broken.
Collaborator
Author
|
Hi @maxceem, I've fixed the issue. Please review the latest |
maxceem
approved these changes
Dec 14, 2020
Collaborator
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
Thanks, @vigneshTheDev works perfectly now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #4130 (comment)