Skip to content

fix: #4206 disblae next button when add empty job #4264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxceem merged 1 commit into from
Jan 13, 2021
Merged

fix: #4206 disblae next button when add empty job #4264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/projects/detail/components/JobsPickerQuestion/JobsPickerQuestion.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,8 @@ class JobsPickerQuestion extends Component {
},
noPartialFillsExist: (formValues, value) => {
return _.every(value, v => {

const isOneValueFilled = v.title.trim().length > 0 || v.people > 0 || v.duration > 0 || (v.skills && v.skills.length) || v.description.trim().length || (v.workLoad && v.workLoad.value !== null) || (v.role && v.role.value !== null)
const isAllValuesFilled = v.title.trim().length > 0 && v.people > 0 && v.duration > 0 && v.skills && v.skills.length && v.description.trim().length && v.workLoad.value !== null && v.role.value !== null
// If one value is filled, all values should be filled to make this row valid. Partial fill is not valid
const isRowValid = !isOneValueFilled || isAllValuesFilled
return isRowValid
return isAllValuesFilled
})
}
}
Expand Down