Skip to content

fix: issue #4263 add validation #4277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxceem merged 1 commit into from
Jan 15, 2021
Merged

fix: issue #4263 add validation #4277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/projects/detail/components/JobPickerRow/JobPickerRow.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ const always = () => true
const never = () => false
const emptyError = () => ''

const MAX_NUMBER = Math.pow(2, 31) - 1

class JobPickerRow extends React.PureComponent {
constructor(props) {
super(props)
Expand Down Expand Up @@ -117,6 +119,7 @@ class JobPickerRow extends React.PureComponent {
value={value.title}
className={cn('tc-file-field__inputs', { error: isRowIncomplete && !value.title.trim() })}
name="title"
maxLength="128"
onChange={this.handleJobTitleChange}
placeholder="Job Title"
/>
Expand Down Expand Up @@ -147,7 +150,7 @@ class JobPickerRow extends React.PureComponent {
<PositiveNumberInput
styleName="noMargin"
className={cn('tc-file-field__inputs', { error: isRowIncomplete && value.people <= 0 })}
max={10000}
max={MAX_NUMBER}
value={value.people || ''}
onChange={this.handlePeopleChange}
onBlur={this.resetPeople}
Expand All @@ -163,7 +166,7 @@ class JobPickerRow extends React.PureComponent {
<PositiveNumberInput
styleName="noMargin"
className={cn('tc-file-field__inputs', {error: isRowIncomplete && value.duration <= 0 })}
max={10000}
max={MAX_NUMBER}
value={value.duration || ''}
onChange={this.handleDurationChange}
onBlur={this.resetDuration}
Expand Down