Skip to content

Conversation

@yoution
Copy link
Collaborator

@yoution yoution commented Feb 21, 2021

No description provided.

@yoution
Copy link
Collaborator Author

yoution commented Feb 21, 2021

@maxceem please review

@yoution
Copy link
Collaborator Author

yoution commented Feb 21, 2021

the react version is not fit for this project, it only support react 16

Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yoution it works great.

There are a few moments that I'd like to improve in code. Could please, kindly check the comments to the code below.

@yoution yoution requested a review from maxceem February 21, 2021 10:30
@yoution
Copy link
Collaborator Author

yoution commented Feb 21, 2021

@maxceem please review

Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for so fast implementation @yoution.

All is perfect now.

@maxceem maxceem merged commit 00a717b into topcoder-archive:dev Feb 21, 2021
@yoution yoution deleted the feature/add-editor branch March 4, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants