Skip to content

Conversation

@yoution
Copy link
Collaborator

@yoution yoution commented Mar 1, 2021

No description provided.

@yoution
Copy link
Collaborator Author

yoution commented Mar 1, 2021

for issue #4301

Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution Approach looks great. But I guess how Ariel wants it to work is, when we click outside it should work the same as if we press Enter or Space. I. e. the value should be created not only keep text:

image

@yoution
Copy link
Collaborator Author

yoution commented Mar 4, 2021

@yoution yoution requested a review from maxceem March 4, 2021 03:41
Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution this is very close to what we need.

The only one thing, when we click outside can we add an option which we enter into the field, not what is chose in the list?

image

The logic is, if we want to select an option, we have to click the option. But if we click outside, we want to select what we enter into the field, not the option.

@yoution yoution requested a review from maxceem March 4, 2021 09:53
Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now @yoution!

@maxceem maxceem merged commit b9bfb71 into topcoder-archive:dev Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants