Skip to content

fix: issue #4315 #4332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxceem merged 2 commits into from
Mar 4, 2021
Merged

fix: issue #4315 #4332

maxceem merged 2 commits into from
Mar 4, 2021

Conversation

@yoution
Copy link
Collaborator

@yoution yoution commented Mar 3, 2021

@maxceem please review

maxceem
maxceem requested changes Mar 3, 2021
View reviewed changes
Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution works great, just a small code improvement below.

@yoution yoution requested a review from maxceem March 4, 2021 00:34
maxceem
maxceem approved these changes Mar 4, 2021
View reviewed changes
Copy link
Collaborator

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @yoution. All is perfect now.

@maxceem maxceem merged commit 8537f27 into topcoder-archive:dev Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxceem maxceem maxceem approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yoution @maxceem