Fix: hide actual phase status from customers #4359
Conversation
|
|
||
| <div styleName="col hide-md"> | ||
| {status && (isSimplePlan || status !== PHASE_STATUS_ACTIVE) && !this.props.currentUserRoles.includes(PROJECT_ROLE_CUSTOMER) && | ||
| {status && (isSimplePlan || status !== PHASE_STATUS_ACTIVE) && !this.props.currentUserRoles.includes(PROJECT_ROLE_CUSTOMER) && this.props.currentUserRoles.length > 2 && |
There was a problem hiding this comment.
@vikasrohit I dont think this solution is good enough. The currentUserRoles sometime has 2 and 3 values.
@diwosuwanto account
@mirzailhami account
Any suggestion @vikasrohit?
There was a problem hiding this comment.
You are right @mirzailhami You don't need to check currentUserRoles. We have to check project role of the logged in user because a user can not see without joining a project (unless he/she is admin). And best way to achieve this is following our new permission model. Example code here https://github.com/appirio-tech/connect-app/blob/7d640885c00323ebef298f022a079384decdb8af/src/projects/detail/containers/DashboardContainer.jsx#L100 and https://github.com/appirio-tech/connect-app/blob/7d640885c00323ebef298f022a079384decdb8af/src/config/permissions.js#L178
There was a problem hiding this comment.
@diwosuwanto Please look into the code reference & suggestion above. You can commit the update, then. Thanks.
There was a problem hiding this comment.
Thank you for the feedback sir @mirzailhami @vikasrohit, i already commit the update. Please check my commit, thank you.
There was a problem hiding this comment.
@mirzailhami @diwosuwanto We need to create new permission instead of reusing EXPAND_ACTIVE_PHASES_BY_DEFAULT. Lets call it SHOW_PHASE_STATUS
mirzailhami
merged commit cc2de86
into
topcoder-archive:feature/project-plan-simplification-0
3 participants
Fix this issue: https://github.com/appirio-tech/connect-app/issues/4348