Feature/topbar filters visual indicator #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 3, 2016 13:36
…to consideration -- Added visual indicator to show the number of filters currently applied on the project listing
…to consideration -- Better way to handle the criteria change. Earlier it was modifying the criteria from the props which was causing no change in state even if we are dispatching and handling GET_PROJECTS_SEARCH_CRITERIA action.
* dev: Github issue #287 after applying search if click on Connect logo, should lands user to project listing page -- Fixed. Now it reloads the page even if user is already on project listing page. Fixed lint errors Github issue #317 [Specification] - no option to remove the color added -- Fixed the edge case bug where user wasn't able to add new colors even if he/she has removed colors after max limit reached. -- Removed colors state variable as it is not needed now because we don't have enable/disable kind of behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.