Skip to content

Conversation

@fnisen
Copy link
Contributor

@fnisen fnisen commented Nov 8, 2016

Changed titles for "Add Link" fields

Changed titles for "Add Link" fields
@vikasrohit
Copy link

This might need some more changes in code as you have changed the field names which might be used in javascript code as well.

@fnisen
Copy link
Contributor Author

fnisen commented Nov 10, 2016

@vikasrohit so do you need me to do something or create an issue?

@vikasrohit
Copy link

Sorry, @fnisen I need to validate the changes which I was not able to do. I would do that on Monday now. Basically, we can change the field label but can't change field name because doing that would require updating all existing projects' data to be updated as well to reflect the same, otherwise we would see blank link titles for existing links in projects.

…links or old links to be rendered as empty or may be throw an error.
@vikasrohit
Copy link

@fnisen I have committed changes to avoid potential issues which could have cause one of new(added after merging this PR without any change) and old(before merging this PR) links to be unable to render properly. There might be some runtime error or the links would have been rendered as empty rows.

@vikasrohit vikasrohit merged commit 2f5ee31 into dev Nov 15, 2016
@fnisen fnisen deleted the fnisen-patch-3 branch November 29, 2016 01:15
@fnisen
Copy link
Contributor Author

fnisen commented Nov 29, 2016

Thank you. 👍 Now live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants