Skip to content

Github issue #351 [Add a Team Member] - the existing username is displayed as autocomplete when set focus #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vikasrohit merged 1 commit into from
Nov 9, 2016
Merged

Github issue #351 [Add a Team Member] - the existing username is displayed as autocomplete when set focus #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/TeamManagement/AutoCompleteInput.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React, {PropTypes} from 'react'
import ReactDOM from 'react-dom'
import uncontrollable from 'uncontrollable'
import { Avatar } from 'appirio-tech-react-components'
import { AUTOCOMPLETE_TRIGGER_LENGTH } from '../../config/constants'

class AutoCompleteInput extends React.Component {

Expand Down Expand Up @@ -52,7 +53,7 @@ class AutoCompleteInput extends React.Component {
return (
<div className="input-icon-group tc-file-field__inputs">

{isPopupVisible && searchMembers.length > 0 &&
{isPopupVisible && keyword.length >= AUTOCOMPLETE_TRIGGER_LENGTH && searchMembers.length > 0 &&
<div className="member-dropdown">
{searchMembers.map(renderMember)}
</div>
Expand Down
2 changes: 2 additions & 0 deletions src/config/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,3 +211,5 @@ export const CODER_BOT_USER_FNAME = 'Coder'
export const CODER_BOT_USER_LNAME = 'Bot'

export const PROJECT_MAX_COLORS = 5

export const AUTOCOMPLETE_TRIGGER_LENGTH = 3
7 changes: 4 additions & 3 deletions src/projects/detail/containers/TeamManagementContainer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { withRouter } from 'react-router'
import _ from 'lodash'
import {
ROLE_CONNECT_COPILOT, ROLE_CONNECT_MANAGER,
PROJECT_ROLE_COPILOT, PROJECT_ROLE_MANAGER, PROJECT_ROLE_CUSTOMER
PROJECT_ROLE_COPILOT, PROJECT_ROLE_MANAGER, PROJECT_ROLE_CUSTOMER, AUTOCOMPLETE_TRIGGER_LENGTH
} from '../../../config/constants'
import TeamManagement from '../../../components/TeamManagement/TeamManagement'
import { addProjectMember, updateProjectMember, removeProjectMember,
Expand Down Expand Up @@ -107,7 +107,7 @@ class TeamManagementContainer extends Component {
}

onKeywordChange(keyword) {
if (keyword.length > 2)
if (keyword.length >= AUTOCOMPLETE_TRIGGER_LENGTH)
this.props.loadMemberSuggestions(keyword)
this.setState({ keyword, selectedNewMember: null })
}
Expand Down Expand Up @@ -135,12 +135,13 @@ class TeamManagementContainer extends Component {
)
this.setState({
keyword: '',
searchMembers: [],
selectedNewMember: null
})
}

onToggleAddTeamMember(isAddingTeamMember) {
this.setState({ isAddingTeamMember, error : null })
this.setState({ isAddingTeamMember, error : null, searchMembers: [] })
}

onToggleNewMemberConfirm(showNewMemberConfirmation) {
Expand Down