Design style 4 #559
Merged
Design style 4 #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o design-style-4 * 'dev' of https://github.com/appirio-tech/connect-app: Fixed lint error Github issue #557, General: restore terms of service page -- Restored terms page from v1. We don't have Proxima Nova font now, so used standard roboto font for now. Update Footer.jsx Update FooterV2 Github issue #541 Project Details: notify user when they are leaving Specification tab without saving changes Github issue #542 Project Specifications || Save buttons should be disabled when form is pristine -- Got them fixed by community. Winner: utkarshkukreti Github issue #543, Change project name search to project keyword search -- Fixed. Removed comment Github issue #544, NPM Install error -- Fixed. It was there because of latest update by react-datetime. They have updated the version (2.7.4) in package.json but forgot to make a release for the same. Github issue #527, Discussions: Discussion thread not showing all posts -- Found critical issue when reviewing the code the mentioned issue. It was causing wrong posts to be shown under a topic. Fixed renaming of the form fields. This could have caused either new links or old links to be rendered as empty or may be throw an error. Github issue #526 Add Team Member || Modal is not visible after clicking on Add button -- Applied fix from winner of the challenge. This fix has least intrusive changes with only two files being changed and only 3 lines of addition overall. Other change which I committed in separate branch (feature/add_team_member_scroll) works fine but has changes in more 6-7 files and requires functional component to be stateful. So, we are going to accept this fix as final solution. Updating copy on AddLink.jsx
… of just an icon.
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes from Didi & my own little additions