Skip to content

Github issue #574, Discussions: no footer on Discussion tab #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vikasrohit merged 1 commit into from
Dec 13, 2016
Merged

Github issue #574, Discussions: no footer on Discussion tab #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/MessageList/MessageList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,9 @@ class MessageList extends Component {
componentDidMount() {
const { scrollPosition } = this.props
const panelMessages = this.refs.panelMessages
// 145 = 60 for topbar + 45 for panel title + 20px for margin between topbar and left panel + 10px padding
panelMessages.style.height = (window.innerHeight - 145) + 'px'
// 215 = 60 for topbar + 45 for panel title + 20px for margin between topbar and left panel + 10px padding
// + 60px footer + 10px margin bw footer and left panel
panelMessages.style.height = (window.innerHeight - 215) + 'px'
if (scrollPosition) {
// We use requestAnimationFrame because this function may be executed before
// the DOM elements are actually drawn.
Expand Down
2 changes: 1 addition & 1 deletion src/projects/detail/Messages.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
@include flexBox;
max-width: 1110px;
margin: 20px auto;
height: calc(100% - 20px);// 20px is for bottom margin
height: calc(100% - 80px);// 20px is for bottom margin, 60px for footer

.left-area {
@include flexWidth(1);
Expand Down