Github issue #572, Messaging: Owner response post missing from status update #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 14, 2016 12:18
… update -- Removed the constraint of user to be a team member of the project in order to view the comments of status updates. Further, I am assuming we need to do the same for Discussions tab as well, so removing the constraint there as well. So, now any user who has the access to the project's dashboard and discussions pages, can view posts and comments.
… update -- Reverted previous changes. Found the root cause of the problem. Actually the flag, to prevent non team member from commenting on posts, was wrongly being used to render the feed's comments section on dashboard. It is used correctly on Discussions page.
vikasrohit
deleted the
feature/comments_remove_restriction_being_memeber
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Fixed.
@parthshah @fnisen fyi, it was a bug not explicitly set condition. Actually the flag, to prevent non team member from commenting on posts, was wrongly being used to render the feed's comments section on dashboard. It is used correctly on Discussions page.