Skip to content

Hotfix/project list sort bestmatch #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthshah merged 2 commits into from
Apr 5, 2017
Merged

Hotfix/project list sort bestmatch #877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a56bb91
Merge branch 'hotfix/codebot-fix'
Mar 20, 2017
e9982bd
fixes #876
Apr 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/TopBar/TopBarContainer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,11 @@ class TopBarContainer extends React.Component {

applyFilters(filter) {
const criteria = _.assign({}, this.props.criteria, filter)
if (criteria && criteria.keyword)
if (criteria && criteria.keyword) {
criteria.keyword = encodeURIComponent(criteria.keyword)
// force sort criteria to best match
criteria.sort = 'best match'
}
this.routeWithParams(criteria, 1)
}

Expand Down
4 changes: 2 additions & 2 deletions src/projects/list/components/Projects/ProjectListProjectColHeader.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import { Dropdown, DropdownItem } from 'appirio-tech-react-components'
const options = [
{ val: 'createdAt desc', label: 'Latest first' },
{ val: 'createdAt', label: 'Oldest first' },
{ val: 'name', label: 'Name A-Z' }
// { val: 'name desc', label: 'Name Z-A' }
{ val: 'name', label: 'Name A-Z' },
{ val: 'best match', label: 'Best Match' }
]

const ProjectListProjectColHeader = ({currentSortField, sortHandler}) => {
Expand Down