Feature/message edit delete #972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- Utilized the on the fly update of other form sections on every form change event. Updated SpecQuestion component to use dirty project value for numberOfScreens question
-- Used highest resolution favicon image from the archive provided initially in the github issue. favicon-webpack-plugin would take care of generating the icons for other devices and browsers.
Github issue#9, Add favicon.ico
-- Trimmed form field value, before checking if it is empty or not, if it is a string.
Github issue#405, White spaces are recognized as valid input for NOTES
…stmatch Hotfix/project list sort bestmatch
-- Implemented scroll to discussion feature on discussions page when URL has specific dicussion specified in it -- Investigated dashboard page to implement the same scroll to feed feature -- Came up with two options: one is to use hash params to specify particular feed and another was to use REST url like we have for discussions page
…thout saving the changes -- Initial commit to update features value in formsy form model
* dev: moving best match to the top of the sort list Github issue#405, White spaces are recognized as valid input for NOTES -- Trimmed form field value, before checking if it is empty or not, if it is a string. fixes #876 Github issue#9, Add favicon.ico -- Used highest resolution favicon image from the archive provided initially in the github issue. favicon-webpack-plugin would take care of generating the icons for other devices and browsers. Update to Connect Terms per Joey's request Github issue#691, Refresh Project Estimate component on change of number of screens -- Fired PROJECT_DIRTY action for every change event fired by the form. Earlier it was firing the PROJECT_DIRTY action only if the form has actually changed its model from the original value. fixes #840 fixing codebot bug fixing bug updating coderbot value and fixes system hardcoded values Conflicts: src/projects/detail/components/EditProjectForm.jsx
-- Removed route for permalink on dashboard. Instead used hash based implementation.
* dev: moving best match to the top of the sort list Github issue#405, White spaces are recognized as valid input for NOTES -- Trimmed form field value, before checking if it is empty or not, if it is a string. fixes #876 Github issue#873, Manager does not get manager access immediately after joining the project -- Updated projectNonDirty state as well on every action that can update project Github issue#9, Add favicon.ico -- Used highest resolution favicon image from the archive provided initially in the github issue. favicon-webpack-plugin would take care of generating the icons for other devices and browsers. Update to Connect Terms per Joey's request Github issue#691, Refresh Project Estimate component on change of number of screens -- Fired PROJECT_DIRTY action for every change event fired by the form. Earlier it was firing the PROJECT_DIRTY action only if the form has actually changed its model from the original value. fixes #840
-- Removed unused params
-- Added back the route params to be passed to FeedContainer component. Not sure, but without this argument, auto scrolling fails to work properly.
* dev: Github issue#873, Manager does not get manager access immediately after joining the project -- Updated projectNonDirty state as well on every action that can update project
…aliation_802 Github issue#802, can add more screen
…save * dev: Github issue#873, Manager does not get manager access immediately after joining the project -- Updated projectNonDirty state as well on every action that can update project Github issue#802, can add more screen -- Utilized the on the fly update of other form sections on every form change event. Updated SpecQuestion component to use dirty project value for numberOfScreens question
…thout saving the changes -- Fixed issue with change alert being shown even after saving the changes.
…reflected_without_save Feature/features change no reflected without save
* dev: Github issue#880, Features changes are not reflected in side panel without saving the changes -- Fixed issue with change alert being shown even after saving the changes. Github issue#880, Features changes are not reflected in side panel without saving the changes -- Initial commit to update features value in formsy form model Github issue#802, can add more screen -- Utilized the on the fly update of other form sections on every form change event. Updated SpecQuestion component to use dirty project value for numberOfScreens question
…_messages Permalink for status post and discussions message
Collaborator
Author
|
@vikasrohit can you check if the merge conflicts would revert any of the hot fixes deployed earlier to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.