Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

Conversation

@deedee
Copy link
Contributor

@deedee deedee commented Oct 13, 2017

For studio will not add entry Environment and Code Repo on project_info. For MM: html related related currently comment out, although will still create entry on project_info

@ajefts ajefts merged commit 37e8286 into topcoder-archive:dev Oct 20, 2017
@ajefts
Copy link
Contributor

ajefts commented Oct 20, 2017

@deedee @skyhit The general functionality looks ok for this. However, it's letting me inject scripts into the form fields. For example, I can add "'><svg/onload=alert(1)> to the env url, which will then run on the page. Can we protect it like we do for project name/desc/etc?

@skyhit
Copy link
Collaborator

skyhit commented Oct 21, 2017

@deedee @ajefts yes, we can use the same approach to convert as project name and description

@deedee
Copy link
Contributor Author

deedee commented Oct 21, 2017

Agree. Or we can create servlet filter to sanitize input? In term of this kind of attack, many places need to be sanitized which not did right now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants