Remove jira #331
Remove jira #331
Conversation
|
|
||
| <property name="game_plan_service.jar" value="${direct_service_libdir}/game_plan_service.jar"/> | ||
|
|
||
| <property name="user_service_facade.jar" value="${direct_service_libdir}/user_service_facade.jar"/> |
There was a problem hiding this comment.
@tuxing1986 it is removed, because of we built from source code?
There was a problem hiding this comment.
yes, it's removed and the user_service_facade under the service directory is also removed.
| <property name="viewData.showJustForm" value="true"/> | ||
| </bean> | ||
|
|
||
| <bean id="dashboardJiraIssuesReportAction" |
There was a problem hiding this comment.
@tuxing1986 these reports are related to JIRA calls, not direct database query?
There was a problem hiding this comment.
dashboardJiraIssuesReportAction will execute "dashboard_jira_issues_report" query in the database.
There was a problem hiding this comment.
@tuxing1986 can you restore the related logic, db query related logic is fine, we just need to remove the JIRA API calls, as we are going to shutdown the JIRA service.
There was a problem hiding this comment.
dashboardJiraIssuesReportAction will also use ServerConfiguration.JIRA_SERVER_NAME indirectly.
Hence, it will invoke the jira calls.
There was a problem hiding this comment.
dashboardJiraIssuesReportAction is for src\web\WEB-INF\report\dashboard-jira-issues-report.jsp
That jsp page will call '${ticketId}' to get the ticket.
Hence all the action, jsp file and the related js file should all be removed.
There was a problem hiding this comment.
call https:/ServerConfiguration.JIRA_SERVER_NAM/browse/ticketId
There was a problem hiding this comment.
@tuxing1986 this seems just linked to the external service, let me double check with PM, and response to you
There was a problem hiding this comment.
okay, all the issues and bug races related to the jira urls, hence they should be removed.
There was a problem hiding this comment.
I can not access my gmail now, please post any issue here, thanks.
| <ul> | ||
| <li><a href="http://www.jboss.org/products/jbossas/docs">JBoss Documentation</a></li> | ||
| <li><a href="http://wiki.jboss.org/">JBoss Wiki</a></li> | ||
| <li><a href="http://jira.jboss.org/">JBoss JIRA</a></li> |
| * </P> | ||
| */ | ||
| private static Overview overview; | ||
| private static Overview overview;; |
| // set project bug race fee configuration | ||
| ProjectData directProjectData = getProjectServiceFacade().getProject(currentUser, | ||
| softwareCompetition.getProjectHeader().getTcDirectProjectId()); | ||
| setFixedBugRaceFee(directProjectData.getFixedBugContestFee()); |
There was a problem hiding this comment.
All the bug fix is related with JIRA.
There was a problem hiding this comment.
@tuxing1986 I mean this value is not related to JIRA API calls, it is just general settings for project, right? if yes, I think we can keep it, it is not harmful, and useful for auditing.
| } else if (keyId == 4L) { | ||
| // svn address | ||
| getViewData().setSvnURL(data); | ||
| } else if (keyId == 5L) { |
There was a problem hiding this comment.
It's related with jira things, why it should be restored?
There was a problem hiding this comment.
@tuxing1986 is not it just related to set the project meta info for Bug Trace, I mean an URL?
| } else if (keyId == 4L) { | ||
| // svn | ||
| getViewData().getProjectGeneralInfo().setSvn(m.getMetadataValue()); | ||
| } else if (keyId == 5L) { |
| metadataOperations.add(getFormData().getBudget()); | ||
| metadataOperations.add(getFormData().getDuration()); | ||
| metadataOperations.add(getFormData().getSvn()); | ||
| metadataOperations.add(getFormData().getJira()); |
| final ProjectData project = getProjectServiceFacade().getProject(DirectUtils.getTCSubjectFromSession(), | ||
| getFormData().getProjectId()); | ||
|
|
||
| // bug race fee |
There was a problem hiding this comment.
@tuxing1986 does this related to JIRA API calls?
| case "failureContestsInput": | ||
| sortIndex = 4; | ||
| break; | ||
| case "bugraceInput": |
There was a problem hiding this comment.
All the bugraces are related to jiras as they are post as jira issues.
| formData.svn = svnUpdate; | ||
| } | ||
|
|
||
| // get project jira address |
2 participants
the components under 'components' directory are not touched