Skip to content

Fix for blanks on submit date #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 29, 2016
Merged

Fix for blanks on submit date #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
066e6b9
show blank submitted date if null
huangqun Aug 28, 2016
2240e36
Update project.list.controller.js
ajefts Aug 29, 2016
ba6ec74
Merge pull request #38 from huangqun/dev
ajefts Aug 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/app/filters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,11 @@ angular.module('supportAdminApp')
};
})
.filter('fmtDate', function () {
return function (date) {
return function (date, blankOnNull) {
if (blankOnNull && !date) {
return '';
}

date = date ? new Date(date) : new Date();
var yyyy = date.getFullYear();
var mm = _.padStart(date.getMonth() + 1, 2, '0');
Expand Down
7 changes: 6 additions & 1 deletion src/app/work/projects.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,12 @@ <h2>Projects</h2>
</a>
{{proj.copilotId === 'unassigned' ? proj.copilotId : ''}}
</td>
<td>{{proj.submittedAt | fmtDate}}</td>
<td>
<!-- display submitted date column
don't supply `true` to fmtDate as second argument, if you want previous behavior
i.e) { proj.submittedAt | fmtDate } -->
{{proj.submittedAt | fmtDate: true }}
</td>
<td>{{proj.status | capitalize }}</td>
<td>{{proj.currentStep}}</td>
<td>
Expand Down