blockchain community and many bug bash fixes/updates #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we cannot show submissions tab for active challenges, as API does not include all necessary information into chalelnge details of active challenges. This fix ensures that, for such challenges, submissions icon-link in the challenge listing directs user to the details page of challenge details.
update qa community settings
update group config
+ misc fixes on the way.
Adds a mock implementation of challenge terms service (both for simple Topcoder terms, and for DocuSign flow). If enabled in config, the app will use it, allowing to test challenge terms flow in a convenient way, and to carry on related development. It also can be used to mock terms service in Jest unit tests.
A few dependencies have not been updated, cause it is cause multiple problems.
Prior to this point, global SCSS styles were copied from tc-ui repo, and used almost as they are, which turns out to be very unefficient. This commit splits all existing global styles into two parts, exposed via separate entry points: "global.scss" is included once at the root level of the app (before it was imported in each component style, and then any dublicates of rules were cleaned out by css optimizer); "mixins.scss" gives access to all variables and mixins, and can be imported per component style. This change: - Drastically improves performance of browser's dev tools in development mode (where css code is not optimized, to keep HMR speed at top); - Most probably improves build time, and overall performance of the app.
Disabled optimization are not safe if styles are split into different bundles, which is our case.
Submission #518674 by ronakkaria to the challenge http://www.topcoder.com/challenge-details/30059252/?type=develop
Submission #518677 from ronakkaria to the challenge http://www.topcoder.com/challenge-details/30059252/?type=develop as a diff from his previous submission
It turns out that our setup does not guarantee that order of styles will match the order of imports (numerous plugins may shake order of CSS, it is something a way too tricky to solve). Generally, it is not a big deal for us, but it is a problem, when react-css-themr deeply merges themes from different sources. It is necessary to be very careful, and use !important rule for the styles that should take priority.
+ preparing to hide the challenge listing when visitor is not a member of community (but this is not finished yet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.