Conversation
What was broken Topgear challenge details previously displayed the Wipro payment terms section. The production removal and regression coverage are already present on the current develop base, but the package lint/test command was blocked by a stale unused import in the challenge-detail test suite. Root cause (if identifiable) The payment text came from a hardcoded Wipro challenge-details section. After that section was removed, the nearby challenge-detail container test still imported mapStateToProps even though the test no longer used it. What was changed Removed the unused mapStateToProps import from the challenge-detail container test so the existing PM-5505/Topgear payment regression coverage and full validation commands run cleanly. Any added/updated tests No new tests were needed because develop already includes a focused challenge-detail specification regression test asserting Wipro/Topgear payment terms are not rendered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Topgear challenge details previously displayed the Wipro payment terms section. The production removal and regression coverage are already present on the current develop base, but the package lint/test command was blocked by a stale unused import in the challenge-detail test suite.
Root cause (if identifiable)
The payment text came from a hardcoded Wipro challenge-details section. After that section was removed, the nearby challenge-detail container test still imported mapStateToProps even though the test no longer used it.
What was changed
Removed the unused mapStateToProps import from the challenge-detail container test so the existing PM-5505/Topgear payment regression coverage and full validation commands run cleanly.
Any added/updated tests
No new tests were needed because develop already includes a focused challenge-detail specification regression test asserting Wipro/Topgear payment terms are not rendered.
Validation