[$400] Custom upload permissions

[jmgasper]

@atelomycterus - Let me know if the payment here is too low and I'll adjust.

Related to the discussion in #369 , we would like to have fine-grained role control over uploads available to users.

[jmgasper]

Challenge https://www.topcoder.com/challenges/ad83ec05-36c4-4e11-83f2-5e66454c28a3 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

[jmgasper]

Challenge https://www.topcoder.com/challenges/ad83ec05-36c4-4e11-83f2-5e66454c28a3 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

[atelomycterus]

@jmgasper Thanks! I am working on it.

[atelomycterus]

@jmgasper
Each category has 'Discussion.Uploads' permission and 'Comment.Uploads'. User clicks on 'New discussion' button.
The category is not selected by default:

User selects a category and uploads files. After uploading files, he changes the category to another but he isn't allowed to upload files for the category. Files have been uploaded on Filestack before posting a discussion. There is no link between files on Filestack and Vanilla categories. What should we do in this case?
Should we validate a discussion body for filestack urls before posting discussion and display 'You don't have permission to upload files for this category' ? But this is somehow strange behavior, since user has already uploaded a number of files.

I am open to your suggestions.

Additional notes
It may be inconvenient for users if we prohibit changing the category after first selection when creating a new discussion. The user can make a mistake and choose the wrong category. User (including Admin/Moderator roles) can't change a category after posting discussion. The 'Move discussion' to another category has been hidden in menu options.

[jmgasper]

@atelomycterus - Whatever's easiest for now is fine, to be honest. If we show a warning at an odd time - I'm OK with that for now because this won't be hit very often in production.

[atelomycterus]

@jmgasper Please apply PRs:

• Issues-373: added custom upload permissions #375
• https://github.com/topcoder-platform/forums-topcoder-editor-plugin/compare/issues-373
  Thanks!

Configure roles

After deploying, you should see new permissions for each category:

Copilot user can attach files, edit/delete other's discussions, but in Roundtables only the admin user should be able to do those actions

• Go to 'Manage Roles & Permissions' page and edit 'copilot' role. Uncheck 'Garden.Uploads.Add' , check 'Vanilla.Discussions.Uploads' and 'Vanilla.Comments.Uploads' for a default category:
  

Known issue (new discussion only)

User is allowed to upload files for 'Category1', not 'Category2'.
User selects 'Category1', uploads a file, Files are uploaded on Filestack before posting a discussion. Then user changes 'Сategory1' to 'Category2' and clicks on 'Post Discussion'.

We can prevent the category from being changed after the user has selected the category. But in general, this will not solve the problem. User can select a category and upload files, and then create a new discussion and copy links.

To prevent the user from doing this, it would be correct to upload to the Filestack only after clicking 'Post Discussion'. This has its pros and cons.