chore(PM-2539): added timeout for prisma service #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| constructor() { | ||
| super({ | ||
| transactionOptions: { | ||
| timeout: process.env.IDENTITY_SERVICE_PRISMA_TIMEOUT || 10000, |
There was a problem hiding this comment.
[❗❗ correctness]
Using process.env.IDENTITY_SERVICE_PRISMA_TIMEOUT directly in the constructor might lead to issues if the environment variable is not set or is set to a non-numeric value. Consider validating the environment variable and providing a fallback mechanism to ensure the timeout is always a valid number.
| super({ | ||
| transactionOptions: { | ||
| timeout: process.env.IDENTITY_SERVICE_PRISMA_TIMEOUT | ||
| ? parseInt(process.env.IDENTITY_SERVICE_PRISMA_TIMEOUT, 10) |
There was a problem hiding this comment.
[❗❗ correctness]
Consider validating the environment variable process.env.IDENTITY_SERVICE_PRISMA_TIMEOUT before parsing it with parseInt. If the value is not a valid number, parseInt will return NaN, which could lead to unexpected behavior. You might want to add a check to ensure the parsed value is a valid number.
kkartunov
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Ticket link - https://topcoder.atlassian.net/browse/PM-2539