Fix for WIpro login in prod #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| select: { user_id: true }, | ||
| }); | ||
| } | ||
| console.log("Looking for user ID: " + profile.userId); |
There was a problem hiding this comment.
[maintainability]
Using console.log for logging is not recommended in production code. Consider using the existing Logger instance for consistent logging and better control over log levels.
| isEnterprise: true, | ||
| }, | ||
| adfs: { | ||
| "wipro-adfs": { |
There was a problem hiding this comment.
[❗❗ correctness]
Changing the provider key from adfs to wipro-adfs may impact existing integrations or configurations that rely on the old key. Ensure that all references to this provider key are updated throughout the codebase and any external systems that interact with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.